Critical response
Shanghai Knights received mixed reviews from critics, with praise for the chemistry between Chan and Wilson, the action sequences, and the fun nature of the film, but strong criticism for the plot.
On review aggregator website Rotten Tomatoes, the film has an approval rating of 66% based on 149 reviews, with an average rating of 5.9/10. The site's consensus states: "A silly, anachronistic mess, but the pairing of Chan and Wilson makes the movie fun."
On Metacritic, the film has a score of 58 out of 100, based on reviews from 33 critics. Audiences surveyed by CinemaScore gave the film a grade "B+" on scale of A to F.
Roger Ebert of the Chicago Sun Times gave the film three out of four stars, calling it "fun in a broad, genial way", but disapproved of the "entirely arbitrary" plot.
Joe Leydon of Variety found it better than its predecessor: "A hugely entertaining and more lavishly mounted follow-up to 2000's Shanghai Noon, the high-concept East-meets-Western – that first teamed [the] top-billed duo – pic rides even taller in the saddle as a fleet and funny crowd-pleaser." Elvis Mitchell of The New York Times gave a positive review, singling out Chan's fight sequences and Wilson's performance, noting how "Wilson gets to steal a part of the movie that Chan is smart enough not to want." Mitchell also praised the "bluntly gorgeous" cinematography, and said Chan's reputation is "resuscitated in the rousing, cheerful sequel", calling it "one of his best." Nathan Rabin of The A.V. Club also praised the chemistry between the two leads, writing, "Chan [...] found the perfect screen buddy in Wilson." Rabin criticized the "thin" plot, but found "there's a greatest-hits element" to Chan's fight scenes.